Skip to content

Disable broken vectorization tests on Windows and use windows-2022 in CI#405

Merged
christiangnrd merged 2 commits intomasterfrom
christiangnrd-patch-1
Jan 31, 2026
Merged

Disable broken vectorization tests on Windows and use windows-2022 in CI#405
christiangnrd merged 2 commits intomasterfrom
christiangnrd-patch-1

Conversation

@christiangnrd
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.84%. Comparing base (a1f79db) to head (6766d90).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files          12       12           
  Lines         736      736           
=======================================
  Hits          595      595           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christiangnrd
Copy link
Member Author

christiangnrd commented Nov 20, 2025

@simeonschaub seems like #379 introduced windows test failures (other than #317) masked by the windows-2025 runners breaking

From worker 3:	ld.lld: error: undefined symbol: _cl_sin(float vector[2])
      From worker 3:	>>> referenced by C:/Users/runneradmin/AppData/Local\pocl/tempfile-70-50-fb-83-fa.o:(_pocl_kernel__Z6kernel13CLDeviceArrayI3VecILi2E7Float32ELi0ELi1EE3sinS2__workgroup)
      From worker 3:	error: linker command failed with exit code 1 (use -v to see invocation)

@simeonschaub
Copy link
Member

Hmm, that's odd! I'd be fine with skipping these tests on windows for now, but would be good to figure out why pocl does not support explicit SIMD on these platforms.

@christiangnrd christiangnrd force-pushed the christiangnrd-patch-1 branch 3 times, most recently from 45b73b6 to 538bb2f Compare November 27, 2025 18:29
@christiangnrd christiangnrd changed the title Switch to windows-2022 in CI until windows-2025 is fixed Disable broken vectorization tests on windows and use windows-2022 in CI Nov 27, 2025
@christiangnrd christiangnrd changed the title Disable broken vectorization tests on windows and use windows-2022 in CI Disable broken vectorization tests on Windows and use windows-2022 in CI Nov 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

@christiangnrd christiangnrd force-pushed the christiangnrd-patch-1 branch 2 times, most recently from 4c3ab5d to 97ac8c1 Compare November 28, 2025 18:28
@christiangnrd christiangnrd force-pushed the christiangnrd-patch-1 branch 2 times, most recently from 0ab80c7 to 3cbd96a Compare December 4, 2025 18:36
@christiangnrd christiangnrd force-pushed the christiangnrd-patch-1 branch 2 times, most recently from 538bb2f to 9fd4276 Compare January 11, 2026 21:36
@christiangnrd
Copy link
Member Author

Merging so CI can be useful again. I opened #415 to keep track of the workaround.

@christiangnrd christiangnrd merged commit 0dc61aa into master Jan 31, 2026
33 of 37 checks passed
@christiangnrd christiangnrd deleted the christiangnrd-patch-1 branch January 31, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants