Merged
Conversation
ararslan
reviewed
Nov 23, 2022
Member
ararslan
left a comment
ararslan
left a comment
There was a problem hiding this comment.
Thank you for doing this! Though clearly the proper fix would have been to take a dependency on NumericalTypeAliases. 
docs/src/counts.md
Outdated
| counts | ||
| proportions | ||
| addcounts!(r::AbstractArray, x::StatsBase.IntegerArray, levels::StatsBase.IntUnitRange) | ||
| addcounts!(r::AbstractArray, x::StatsBase.AbstractArray{<:Integer}, levels::StatsBase.IntUnitRange) |
Member
There was a problem hiding this comment.
Suggested change
| addcounts!(r::AbstractArray, x::StatsBase.AbstractArray{<:Integer}, levels::StatsBase.IntUnitRange) | |
| addcounts!(r::AbstractArray, x::AbstractArray{<:Integer}, levels::StatsBase.IntUnitRange) |
I guess IntUnitRange could be similarly removed, as it's an alias for UnitRange{<:Integer}.
docs/src/scalarstats.md
Outdated
| nquantile | ||
| quantile | ||
| Statistics.median(v::StatsBase.RealVector, w::AbstractWeights{<:Real}) | ||
| Statistics.median(v::StatsBase.AbstractVector{<:Real}, w::AbstractWeights{<:Real}) |
Member
There was a problem hiding this comment.
Suggested change
| Statistics.median(v::StatsBase.AbstractVector{<:Real}, w::AbstractWeights{<:Real}) | |
| Statistics.median(v::AbstractVector{<:Real}, w::AbstractWeights{<:Real}) |
Member
Author
|
Updated |
yuyichao
added a commit
to yuyichao/Clustering.jl
that referenced
this pull request
Dec 13, 2022
ararslan
pushed a commit
to JuliaStats/Clustering.jl
that referenced
this pull request
Dec 14, 2022
kagalenko-m-b
pushed a commit
to kagalenko-m-b/StatsBase.jl
that referenced
this pull request
Feb 14, 2023
ararslan
added a commit
to JuliaStats/MLBase.jl
that referenced
this pull request
Aug 17, 2023
* import numerical array types from NumericalTypeAliases and not StatsBase * add CompatHelper action * replaced uses of type aliases with their definitions in the same manner as JuliaStats/StatsBase.jl#840 * Include both StatsBase 0.33 and 0.34 in compat Co-authored-by: Alex Arslan <ararslan@comcast.net> --------- Co-authored-by: Alex Arslan <ararslan@comcast.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the comment in
common.jlsays, these are obsolete now with the terse covariant syntax.Interestingly, there is apparently a whole package just for these type alises: https://github.com/AP6YC/NumericalTypeAliases.jl/blob/develop/README.md#aliases.