Fix type of argument of weighted quantile function#977
Merged
Conversation
andreasnoack
approved these changes
Nov 10, 2025
nalimilan
added a commit
that referenced
this pull request
Dec 14, 2025
This is consistent with `Statistics.quantile` and avoids breakage due to #977. It's particularly useful for `Union{T, Missing}`, e.g. a view of nonmissing entries in a vector. This also allows supporting some types such as `Date`, though currently this only works for some values (would need to implement `type=1`).
nalimilan
added a commit
that referenced
this pull request
Dec 14, 2025
This is consistent with `Statistics.quantile` and avoids breakage due to #977. It's particularly useful for `Union{T, Missing}`, e.g. a view of nonmissing entries in a vector. This also allows supporting some types such as `Date`, though currently this only works for some values (would need to implement `type=1`).
nalimilan
added a commit
that referenced
this pull request
Dec 17, 2025
This is consistent with `Statistics.quantile` and avoids breakage due to #977. It's particularly useful for `Union{T, Missing}`, e.g. a view of nonmissing entries in a vector. This also allows supporting some types such as `Date`, though currently this only works for some values (would need to implement `type=1`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was introduced unintentionally when the old type aliases were removed in #840.