buildsys: cmake install .pc file for pkg-config#222
buildsys: cmake install .pc file for pkg-config#222leleliu008 wants to merge 1 commit intoJuliaStrings:masterfrom leleliu008:cmake-install-pc-file-for-pkg-config
Conversation
version.txt
Outdated
| @@ -0,0 +1 @@ | |||
| 2.6.1 | |||
There was a problem hiding this comment.
I'd rather not have this file — it's yet another place we'll have to update when we bump the version. Why can't the make variables be used?
There was a problem hiding this comment.
OK. I will remove this file.
CMakeLists.txt
Outdated
| set(INCLUDEDIR include) | ||
| set(VERSION 2.6.1) | ||
| configure_file(libutf8proc.pc.in libutf8proc.pc @ONLY) | ||
| install(FILES ${CMAKE_BINARY_DIR}/libutf8proc.pc DESTINATION lib/pkgconfig) |
There was a problem hiding this comment.
Hardcoded destination feels wrong. You should use GNUInstallDirs so downstream users don't have to patch lib to be lib64
There was a problem hiding this comment.
Kind of dependent on #159 I guess.
There was a problem hiding this comment.
Thank you for your suggestion. I have changed it.
|
I think something like this would reduce maintence even further, not by a huge margin though. |
|
closedd by #224 |
4 participants
modified
libutf8proc.pc.in, changed fromPREFIXto@PREFIX@, changed fromVERSIONto@VERSION@, beacuse@VAR@can be replaced by CMake'sconfigure_filecommand.