Skip to content

Fix cmake install#224

Merged
stevengj merged 1 commit intoJuliaStrings:masterfrom
markus-oberhumer-forks:fix-cmake-install
Dec 17, 2021
Merged

Fix cmake install#224
stevengj merged 1 commit intoJuliaStrings:masterfrom
markus-oberhumer-forks:fix-cmake-install

Conversation

@markus-oberhumer
Copy link
Contributor

No description provided.

@markus-oberhumer
Copy link
Contributor Author

I've just pushed a new version - this should also include the functionality of #222 .

project (utf8proc VERSION 2.6.1 LANGUAGES C)

# This is the ABI version number, which may differ from the
# API version number (defined in utf8proc.h).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here to remind us that the API version number should also be set in the project statement above when it is updated in utf8proc.h.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here to remind us that the API version number should also be set in the project statement above when it is updated in utf8proc.h.

Might be a good idea - please merge this and then adapt to your liking.

@markus-oberhumer
Copy link
Contributor Author

Please merge this - the current git is broken as it installs headers into a directory called include64.

Furthermore this would also fix the following issues: #198, #200, #221, #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants