More tests for Core#4396
Merged
Merged
Conversation
HebaruSan
added
Bug
Pull Request Test Coverage Report for Build 15714778159Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#4383 added coverage with Coveralls, and #4392 added some tests for Netkan. Core still has several files with 0% coverage.
Changes
Now we have tests for:
ByteRateCounterExporter(and all the other exporters it provides)JsonToGamesDictionaryConverterKnownGamesModuleImporterModuleTagListStabilityToleranceConfigSteamLibrary(including checks for the corrupted file issues from [Bug]: ValveKeyValue.KeyValueException: Found end of file when another token type was expected #4197, [Bug]: Crash on startup with 1.35+, cannot deserialize a non-array value to type "System.Collections.Generic.List`1 #4278, and The path is not of a legal form in NonSteamGame.NormalizeDir #4293)SuppressedCompatWarningIdentifiersSide changes
./build.sh test --where='namespace=Tests.Core'syntax now works with net8.0CkanExporter, I noticed that the generated .ckan file had"kind": 1,, which should be a string according to the spec. Apparently 4a6df21 broke serialization of this property.Now it's fixed (and tested).
ModuleImporter, I noticed that it would only prompt to install if the identifier was already defined in the user's available modules and compatible. This doesn't make sense, since the goal of Use internal ckan and version file to install unrecognized ZIPs #4327 was to be able to install mods with no metadata in CKAN-meta.Now you're prompted to install anything with compatible
ksp_version_*properties. Note that if it depends on something incompatible, you won't find out about that until the install starts.GameInstanceManager.SteamLibraryis instantiated on-demand instead of unconditionally in the constructor, to improve performance in flows that don't need it (such as many tests).NetkanTransformer.InjectVersionedOverrideTransformersis refactored to allow the deletion ofVersionedOverrideTransformer.AddBeforeandVersionedOverrideTransformer.AddAfter, with equal or better performance.