Skip to content

fix: subEnvironment's id should be real id instead of n/a - INS-3802#7339

Merged
ihexxa merged 2 commits intodevelopfrom
fix-render-env-id
Apr 30, 2024
Merged

fix: subEnvironment's id should be real id instead of n/a - INS-3802#7339
ihexxa merged 2 commits intodevelopfrom
fix-render-env-id

Conversation

@ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Apr 30, 2024

Background

The render function accepts environment as string (env id) or as Environment for making it work for modified environment (by pre-request script). But its id is not correctly set here.
The environment is transient but it still would affect some of downstream plugin, which consume it. ref
This tiny change fixes it.

Change

  • subEnvironment's id should be real id instead of n/a

@ihexxa ihexxa self-assigned this Apr 30, 2024
@ihexxa ihexxa changed the title fix: subEnvironment's id should be real id instead of n/a fix: subEnvironment's id should be real id instead of n/a - INS-3802 Apr 30, 2024
@ihexxa ihexxa enabled auto-merge (squash) April 30, 2024 08:35
@ihexxa ihexxa merged commit fcc8bee into develop Apr 30, 2024
@ihexxa ihexxa deleted the fix-render-env-id branch April 30, 2024 08:47
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants