-
-
Notifications
You must be signed in to change notification settings - Fork 264
Tweak ts tests #479
Tweak ts tests #479
Conversation
|
Supersedes #475 |
|
Yeah, I was going to make the same change; but had to pop out this afternoon. Mind if I pull from this fork to carry on? I still think there are a few refinements to be made before merger. |
|
@MeirionHughes Sure go ahead! |
|
Instead of spawning a ts-node process for each test file, I suggest: "scripts": {
"test": "standard && node test | faucet && npm run ts-test",
"ts-test": "ts-node --no-cache test"
}Then in const fs = require('fs')
const path = require('path')
fs.readdirSync(__dirname)
.filter(f => /-test.js/.test(f))
.forEach(f => require(path.join(__dirname, f)))That's basically what tape was doing anyway, and this works for both node and ts-node. WDYT? Also when I tested this, I had to do |
|
@vweevers PR! 😉 |
|
Against which branch? |
|
@vweevers master |
|
I've just pulled from upstream and I think this broke the test for me; |
|
@MeirionHughes can you try my branch (#480)? |
|
just about to pull from it. :P I wish github pr requests would give you the pull url for a pr. :D |
|
ahh, lol, you didn't fork. I was trying to add you as a remote. doh! |
|
@vweevers yes, that appears to have fixed it - its running on Win10 |
Turns out
faucetis causing problems. Also don't need buster to runts-node.