Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Conversation

@vweevers
Copy link
Member

@vweevers vweevers mentioned this pull request Sep 11, 2017
@MeirionHughes MeirionHughes self-requested a review September 11, 2017 08:23
Copy link
Member

@MeirionHughes MeirionHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • both tests run and return 0 on no error.
  • npm test can fail on normal test fail.
  • npm test can fail on typing fail.


fs.readdirSync(__dirname)
.filter(f => /-test.js/.test(f))
.forEach(f => require(path.join(__dirname, f)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner :)

@ralphtheninja ralphtheninja merged commit f0336c8 into master Sep 11, 2017
@ralphtheninja ralphtheninja deleted the ts-test-optim branch September 11, 2017 10:47
@ralphtheninja
Copy link
Member

v2.0.0-rc2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants