ALFMOB-158: Update PDP Button Copy Based on Item State#44
Draft
Conversation
JoaoPinhoMinder
force-pushed
the
task/ALFMOB-158-update-pdp-button-copy-based-on-item-state
branch
from
f5d495f to
6b6da16
Compare
Contributor
JoaoPinhoMinder
force-pushed
the
task/ALFMOB-158-update-pdp-button-copy-based-on-item-state
branch
from
6b6da16 to
6f67ef7
Compare
JoaoPinhoMinder
changed the base branch from
main
to
task/ALFMOB-162-improve-wishlist-functionality-on-plp-and-wishlist
JoaoPinhoMinder
force-pushed
the
task/ALFMOB-162-improve-wishlist-functionality-on-plp-and-wishlist
branch
from
ae00fcf to
18bc8b0
Compare
- Added `productsPublisher` to both `WishlistService` and `BagService` to enable real-time updates of button titles based on item state. - Updated all relevant view models to observe `productsPublisher` instead of using the previous `getWishlistContent` and `getBagContent` methods. - Adjusted button titles dynamically to reflect the correct state (`"Add to Bag"` / `"Remove from Bag"` and `"Add to Wishlist"` / `"Remove from Wishlist"`). - Ensured that changing color resets both buttons, while changing size only resets the `"Add to Bag"` button (since wishlist state is unaffected by size). - Added necessary localized strings to `L10n` table.
JoaoPinhoMinder
force-pushed
the
task/ALFMOB-158-update-pdp-button-copy-based-on-item-state
branch
from
6f67ef7 to
060e707
Compare
Contributor
Board Review — ALFMOB-158: PDP Button Copy🔴 Blocked — Depends on ALFMOB-162 rewriteThis draft PR depends on PR #42 (ALFMOB-162) which requires a full rewrite due to merge conflicts with the modular architecture refactor (ALFMOB-184). Next steps: Once ALFMOB-162 is reimplemented on the new architecture, this feature should also be reimplemented fresh on top of it. The feature requirements (dynamic Add/Remove button text based on item state) remain valid — use this PR as a spec reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://mindera.atlassian.net/browse/ALFMOB-158
Depends on: #42
Description
productsPublisherto bothWishlistServiceandBagServiceto enable real-time updates of button titles based on item state.productsPublisherinstead of using the previousgetWishlistContentandgetBagContentmethods."Add to Bag"/"Remove from Bag"and"Add to Wishlist"/"Remove from Wishlist")."Add to Bag"button (since wishlist state is unaffected by size).L10ntable.Evidences
Screen.Recording.2025-03-13.at.13.21.27.mov