fix: Log exception and error in FirstRankPerNode before exiting#1468
Merged
fix: Log exception and error in FirstRankPerNode before exiting#1468
Conversation
Signed-off-by: Abhishree <abhishreetm@gmail.com>
athitten
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
akoumpa and
hemildesai
as code owners
athitten
changed the title
Contributor
|
/ok to test 76f6dd5 |
thomasdhc
approved these changes
Mar 10, 2026
Contributor
thomasdhc
left a comment
thomasdhc
left a comment
There was a problem hiding this comment.
Fast merge skip codecov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
FirstRankPerNode() silently quit when there was an error/exception making the real error invisible and hard to debug. This PR logs the error before exiting which is useful.
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information