Skip to content

fix: Log exception and error in FirstRankPerNode before exiting #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasdhc merged 1 commit into from
Mar 10, 2026
Merged

fix: Log exception and error in FirstRankPerNode before exiting #1468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions nemo_automodel/components/distributed/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,14 @@ def __exit__(self, exc_type, exc_val, exc_tb):
if not success:
logger.warning("Barrier timed out during exit, continuing anyway")
if exc_type is not None:
# TODO: propagate failure to the entire job
quit(1)
# Log the exception and make the error visible
logger.error(
"Exception inside FirstRankPerNode: %s: %s",
exc_type.__name__,
exc_val,
exc_info=(exc_type, exc_val, exc_tb),
)
raise SystemExit(1) from exc_val
finally:
if self._created_pg:
dist.destroy_process_group()
Expand Down
Loading