Add option for LoRA with Transformer Engine op fuser#14411
Merged
gautham-kollu merged 34 commits intoNVIDIA-NeMo:mainfrom Sep 10, 2025
Merged
Add option for LoRA with Transformer Engine op fuser#14411gautham-kollu merged 34 commits intoNVIDIA-NeMo:mainfrom
gautham-kollu merged 34 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Missing all-gather op Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
cuichenx
reviewed
Aug 12, 2025
Collaborator
cuichenx
left a comment
There was a problem hiding this comment.
Thanks for the PR! Do you have any data on the performance benefits of fused lora?
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com>
Collaborator
Author
|
Currently I don't see a significant difference between the fused and unfused impl (174 ms/step with a small Llama model on B200). We skip one add (fused into dgrad GEMM), but the dropout implementation is quite unoptimized. We should see speedup as more fusions are supported in TE. |
ko3n1g
previously approved these changes
Sep 3, 2025
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: timmoon10 <timmoon10@users.noreply.github.com>
gautham-kollu
previously approved these changes
Sep 8, 2025
Collaborator
gautham-kollu
left a comment
There was a problem hiding this comment.
Need to revert the manifest.json before merging
Signed-off-by: gautham-kollu <gkollu@nvidia.com>
gautham-kollu
approved these changes
Sep 9, 2025
chtruong814
approved these changes
Sep 9, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds a variant of the
LoRALinearmodule using Transformer Engine's operation fuser. It also adds logic in the existingLoRALinearmodule so that it can call the fused variant. This is an experimental feature.Collection: NLP
Changelog
TEFusedLoRALinearmodule that implements LoRA with TE op fuser.LoRALinearmodule to internally callTEFusedLoRALinear.Usage
Set
use_transformer_engine_op_fuser=Truein the LoRA model config (see #13776).GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information