[PyTorch] Avoid registering FP8 scale update in ops without backward pass#2063
Merged
timmoon10 merged 2 commits intoNVIDIA:mainfrom Aug 14, 2025
Merged
[PyTorch] Avoid registering FP8 scale update in ops without backward pass#2063timmoon10 merged 2 commits intoNVIDIA:mainfrom
timmoon10 merged 2 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
Collaborator
Author
|
/te-ci pytorch |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We keep track of the first TE module within an
fp8_autocastcontext so that we can perform an FP8 scale update during its backward pass. However, the op fuser does not consider the possibility that it might not perform a backward pass. This was causing divergence problems in some finetuning workflows where the first layer does not require any grads.Type of change
Changes
Checklist: