fix: Incorrect error is shown when xcrun simctl is not configured#3514
Merged
rosen-vladimirov merged 1 commit intoreleasefrom Apr 3, 2018
Merged
fix: Incorrect error is shown when xcrun simctl is not configured#3514rosen-vladimirov merged 1 commit intoreleasefrom
rosen-vladimirov merged 1 commit intoreleasefrom
Conversation
In case `xcrun simctl` throws some error, CLI does not handle it very well. Improve the logic in ios-sim-portable and update its version in order to resolve the issue.
Fatme
approved these changes
Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case
xcrun simctlthrows some error, CLI does not handle it very well.Improve the logic in ios-sim-portable and update its version in order to resolve the issue.
PR Checklist
What is the current behavior?
In case simctl is not configured correctly, CLI fails with
process.send is not a function.What is the new behavior?
CLI prints the message from simctl, which shows the user what is misconfigured