Conversation
There was a problem hiding this comment.
I've had a handful of interactions with @Bot-wxt1221 and he knows his stuff! I'd definitely trust him with the bit.
(He's not an automated account in case anyone was confused... which apparently has happened before?)
|
On your last application, Emily raised some good points regarding some communication flaws and your tendency to rush through testing in favour of getting packages merged as quickly as possible. Do you have anything further to add, now that you have another 11 months of experience with our procedures? |
|
@SigmaSquadron . Full testing matters more than merging quickly as this is the official repo of nix. As I become committer, I would test the basic function or see author test it properly. When critical bug come, the first to do is to fix(including revert changes). UPD: Considering question from Emily previously
The standard is that app work fine. But it is always impossible to test every package by myself especially some I don't use. I will test its basic function(like whether it could be started). This could be relaxed when the package maintainer raised the PR. And all in all, I would request maintainer to prove whether it works well when neccessary(like the software's function is complex). When a new package came, I would ask how users use it and test it locally(to prevent my previous fault). It is also useful to enable test if it has. |
As I had requested before. I believe I have followed the guideline of a package maintainer, consistently improving the quaility of nixpkgs packages:
NixOS/nixpkgs#420530 I focus on report from community and mark it insecure at the moment the problem is mentioned.)
NixOS/nixpkgs#418733
I would show previous application here: #50 (comment)
@r-ryantm@r-ryantm@r-ryantm