clash-verge-rev: move IPC path to /run/clash-verge-rev/service.sock for better security#420530
clash-verge-rev: move IPC path to /run/clash-verge-rev/service.sock for better security#420530symphorien merged 2 commits intoNixOS:masterfrom
Conversation
|
Hi @Bot-wxt1221 can you rephrase your PR description? Also, please describe what kind of operations are prevented for easier understanding of the significance of the PR. |
|
@Prince213 It's clear. This program will create IPC for other programs in userspace. This systemd harden options is typical. |
->
Also, https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html
Does the program try to write to /tmp? If so shouldn't it be allowed to do that? |
|
@Prince213 It place his IPC under /tmp. We need /tmp for everyone to read. Or we move it to another place. |
|
What about we place this in /run with RuntimeDirectory? https://0pointer.net/blog/projects/tmp.html
|
|
Issue has been filed upstream: clash-verge-rev/clash-verge-service#13 |
…or better security
… for better security
move socket path to /run/clash-verge-rev/service.sock
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.