Conversation
|
@bovirus Please fix the CI build errors. |
I don't think the CI build errors can be blamed on this PR - as far as I can see, @bovirus is updating Now, why this is happening now and never before? Github updates behind our backs? @ordex can you have a look at the italian updates, please? |
... this said, there are different CI build errors here. The msvc-x64 instance complains about which very much is caused by The patch introduces two new strings, of which this is one. @bovirus please fix this part (do not introduce new messages unless this is something that is actually missing in the italian translation), and we look at the farsi part. |
I was referring to the undefined key erros due to re-introduction of strings that we removed in a recent patch. The error message in the mingw build is very cryptic though.. The one about bidirectional control characters in the farsi files are warnings that I've been ignoring for a while now... |
|
Thanks for explaining. This was non-obvious to me at first, so might have confused others too (and the way Github presents "warnings" and "failures" isn't exactly helping) |
Please check and merge. Thanks.