Skip to content

Italian language update#808

Closed
bovirus wants to merge 1 commit intoOpenVPN:masterfrom
bovirus:master
Closed

Italian language update#808
bovirus wants to merge 1 commit intoOpenVPN:masterfrom
bovirus:master

Conversation

@bovirus
Copy link
Copy Markdown
Contributor

@bovirus bovirus commented Apr 3, 2026

Please check and merge. Thanks.

@selvanair
Copy link
Copy Markdown
Collaborator

@bovirus Please fix the CI build errors.

@cron2
Copy link
Copy Markdown
Contributor

cron2 commented Apr 4, 2026

@bovirus Please fix the CI build errors.

I don't think the CI build errors can be blamed on this PR - as far as I can see, @bovirus is updating res/openvpn-gui-res-it.rc, while the build errors are from a (somewhat misguided?) attempt to block left-right-writing-order shenannigans, complaining about openvpn-gui-res-fa.rc (Farsi, I guess, which sounds like it would use this).

Now, why this is happening now and never before? Github updates behind our backs?

@ordex can you have a look at the italian updates, please?

@cron2
Copy link
Copy Markdown
Contributor

cron2 commented Apr 4, 2026

@bovirus Please fix the CI build errors.

I don't think the CI build errors can be blamed on this PR - as far as I can see, @bovirus is updating res/openvpn-gui-res-it.rc, while the build errors are from a (somewhat misguided?) attempt to block left-right-writing-order shenannigans, complaining about openvpn-gui-res-fa.rc (Farsi, I guess, which sounds like it would use this).

... this said, there are different CI build errors here. The msvc-x64 instance complains about

  Error: D:\a\openvpn-gui\openvpn-gui\plap\../res/openvpn-gui-res-it.rc(369): error RC2104: undefined keyword or key name: IDS_ERR_ONE_CONN_OLD_VER [D:\a\openvpn-gui\openvpn-gui\out\build\x64-ovpn3\libopenvpn_plap.vcxproj]

which very much is caused by openvpn-gui-res-it.rc.

The patch introduces two new strings, of which this is one. @bovirus please fix this part (do not introduce new messages unless this is something that is actually missing in the italian translation), and we look at the farsi part.

@bovirus bovirus closed this Apr 4, 2026
@selvanair
Copy link
Copy Markdown
Collaborator

I don't think the CI build errors can be blamed on this PR

I was referring to the undefined key erros due to re-introduction of strings that we removed in a recent patch. The error message in the mingw build is very cryptic though..

The one about bidirectional control characters in the farsi files are warnings that I've been ignoring for a while now...

@cron2
Copy link
Copy Markdown
Contributor

cron2 commented Apr 4, 2026

Thanks for explaining. This was non-obvious to me at first, so might have confused others too (and the way Github presents "warnings" and "failures" isn't exactly helping)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants