Changes to error offsets, fixing inconsistencies#756
Conversation
08775ee to
cccf7bd
Compare
In the latest version of libpcre2, the offsets appearing in some "compilation failed" warnings have increased by one, as a result of PCRE2Project/pcre2#756 This is causing spurious test failures, so in this commit we replace the hard-coded offsets by %d to match any integer. Gentoo-bug: https://bugs.gentoo.org/965018
In the latest version of libpcre2, the offsets appearing in some "compilation failed" warnings have increased by one, as a result of PCRE2Project/pcre2#756 This is causing spurious test failures, so in this commit we replace the hard-coded offsets by a regex that matches both values. Gentoo-bug: https://bugs.gentoo.org/965018
In the latest version of libpcre2, the offsets appearing in some "compilation failed" warnings have increased by one, as a result of PCRE2Project/pcre2#756 This is causing spurious test failures, so in this commit we replace the hard-coded offsets by a regex that matches both values. Gentoo-bug: https://bugs.gentoo.org/965018 Closes GH-20397
|
If I pass |
|
In Perl, if I try the regex: my $regex = qr/.*.*$*X/;The error message is However if I try the (similar) Perl's error offset is consistently pointing to the caret position in between the In I am satisfied that this is consistent with the way Perl reports error messages, with the offset just to the right of the error. The change was intentional. I apologise if this has caused problems for your application. In a future version of PCRE2, I plan to add a function to retrieve the "error direction" to improve on the current "error offset". The error direction would indicate to text-based applications whether the error is |
Fine by me. Except the reporting has to be different for 10.47+ and earlier versions... |
Part of #549