Closed
Conversation
orlitzky
force-pushed
the
test-support-for-libpcre2-10.47
branch
from
c86275d to
cfd8972
Compare
github-actions
bot
added
Extension: pcre
and removed
Category: Build System
Category: Engine
Category: Optimizer
ABI break
labels
Contributor
Author
|
(Sorry, I forgot to rebase on 8.3 before opening the PR and confused the hell out of the label/review bot.) |
iluuu1994
reviewed
Nov 5, 2025
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Assuming the change in libpcre2 is intentional.
ext/pcre/tests/grep2.phpt
Outdated
| ?> | ||
| --EXPECTF-- | ||
| Warning: preg_grep(): Compilation failed: quantifier does not follow a repeatable item at offset 0 in %sgrep2.php on line %d | ||
| Warning: preg_grep(): Compilation failed: quantifier does not follow a repeatable item at offset %d in %sgrep2.php on line %d |
Contributor
Author
There was a problem hiding this comment.
Because I forgot about %r :)
Done!
Contributor
Author
|
It was intentional, I went digging: PCRE2Project/pcre2#756 |
orlitzky
force-pushed
the
test-support-for-libpcre2-10.47
branch
from
cfd8972 to
245b796
Compare
In the latest version of libpcre2, the offsets appearing in some "compilation failed" warnings have increased by one, as a result of PCRE2Project/pcre2#756 This is causing spurious test failures, so in this commit we replace the hard-coded offsets by a regex that matches both values. Gentoo-bug: https://bugs.gentoo.org/965018
orlitzky
force-pushed
the
test-support-for-libpcre2-10.47
branch
from
245b796 to
5f61eeb
Compare
Member
|
Thank you @orlitzky! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the latest version of libpcre2, the offsets appearing in some "compilation failed" warnings have increased by one due to PCRE2Project/pcre2#756. This is causing spurious test failures, so in this commit we replace the hard-coded offsets by
%dto match any integer.An example failure:
This was originally reported as https://bugs.gentoo.org/965018