Copy forward when registering alias (fixes #10827)#10952
Closed
ookiegajwa wants to merge 1 commit intoPaperMC:masterfrom
Closed
Copy forward when registering alias (fixes #10827)#10952ookiegajwa wants to merge 1 commit intoPaperMC:masterfrom
ookiegajwa wants to merge 1 commit intoPaperMC:masterfrom
Conversation
Member
|
Thanks for the PR! Looks good to me, not sure why that wasn’t originally done… that bit of code was missing some logic previously :P |
kennytv
added
the
priority: high
kennytv
force-pushed
the
fix/brigadier-redirects
branch
2 times, most recently
from
6f74e5f to
53345db
Compare
kennytv
approved these changes
Jul 15, 2024
ookiegajwa
force-pushed
the
fix/brigadier-redirects
branch
from
53345db to
519cd7f
Compare
Contributor
Author
|
Rebased to 1.21.1, tested again, still works :) |
ookiegajwa
force-pushed
the
fix/brigadier-redirects
branch
from
519cd7f to
92b4031
Compare
ookiegajwa
force-pushed
the
fix/brigadier-redirects
branch
from
92b4031 to
c10d571
Compare
When flattening any command or registering an alias to a node with no direct children (such as a redirect), the code now takes into account any potential redirect/fork/forward on the target node. This fixes the issue where, when registering a command that was simply a redirect, only the namespaced literal would work, and not any aliases of the command.
ookiegajwa
force-pushed
the
fix/brigadier-redirects
branch
from
c10d571 to
7a8e878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When flattening any command or registering an alias to a node with no direct children (such as a redirect), the code now takes into account any potential redirect/fork/forward on the target node. This fixes the issue where, when registering a command that was simply a redirect, only the namespaced literal would work, and not any aliases of the command.
This fixes #10827, and is now correctly based on a non-
masterbranch :)