Copy forward when registering alias (fixes #10827)#11794
Closed
ookiegajwa wants to merge 1 commit intoPaperMC:mainfrom
Closed
Copy forward when registering alias (fixes #10827)#11794ookiegajwa wants to merge 1 commit intoPaperMC:mainfrom
ookiegajwa wants to merge 1 commit intoPaperMC:mainfrom
Conversation
When flattening any command or registering an alias to a node with no direct children (such as a redirect), the code now takes into account any potential redirect/fork/forward on the target node. This fixes the issue where, when registering a command that was simply a redirect, only the namespaced literal would work, and not any aliases of the command.
Owen1212055
approved these changes
Dec 27, 2024
Member
Owen1212055
left a comment
Owen1212055
left a comment
There was a problem hiding this comment.
Looks good to me, the intention of that code is to essentially make that new node act identical to redirectTo, rather than redirecting to redirectTo. This avoids some vanilla bugs.
This was missed, it seems.
Member
|
Superceeded and fixed by #11954 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When flattening any command or registering an alias to a node with no direct children (such as a redirect), the code now takes into account any potential redirect/fork/forward on the target node. This fixes the issue where, when registering a command that was simply a redirect, only the namespaced literal would work, and not any aliases of the command.
This fixes #10827 and has been reopened post hard-fork from #10952