Don't auto-create any brig redirects#11954
Merged
Machine-Maker merged 6 commits intoPaperMC:mainfrom Feb 16, 2025
Merged
Conversation
Machine-Maker
force-pushed
the
fix/brig-redirects
branch
from
9e69193 to
3da77e7
Compare
lynxplay
force-pushed
the
fix/brig-redirects
branch
from
5b1d5ab to
284efc0
Compare
lynxplay
force-pushed
the
fix/brig-redirects
branch
from
284efc0 to
79f105c
Compare
lynxplay
approved these changes
Feb 16, 2025
Contributor
|
|
lynxplay
force-pushed
the
fix/brig-redirects
branch
from
79f105c to
b1e0d0e
Compare
booky10
added a commit
to booky10/Paper
that referenced
this pull request
Mar 3, 2025
The redirect flattening previously copied over children nodes without checking node requirements (e.g. permissions) Before PaperMC#11954, this issue caused node requirements to be ignored for second-level command nodes created using the brigadier api (if namespaced commands were prevented from being sent using the spigot config option) Since PaperMC#11954 is merged now, it's much less of an issue
booky10
added a commit
to booky10/Paper
that referenced
this pull request
May 7, 2025
The redirect flattening previously copied over children nodes without checking node requirements (e.g. permissions) Before PaperMC#11954, this issue caused node requirements to be ignored for second-level command nodes created using the brigadier api (if namespaced commands were prevented from being sent using the spigot config option) Since PaperMC#11954 is merged now, it's much less of an issue But as PaperMC#12136 has been merged, it still is an issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #11794
Supersedes #11953
Fixes #10827
Fixes #11647
Fixes #11384
Don't automatically create any brig-style redirects. For alises and
namespace:command, just copy over the requirement, command, redirect and children to a new literal. Also do this for the vanilla namespaced commands. This should solve all redirect issues (at least the ones not inherently part of brig itself like nested redirects).