Skip to content

TEST: Add tests for game_theory/lemke_howson.py #302

Closed

Description

@mmcky

Coverage

game_theory/lemke_howson.py            152    122    20%

This has a similar issue to #300. Coverage is driven by internal private functions. As long as all internal functions are testing through lemke_howson() calls we should probably add # pragma: no cover to internal functions to fix the coverage statistics.

Activity

  1. mmcky commented on Apr 12, 2017

    @mmcky
    ContributorAuthor

    @oyamad do you agree with adding the no cover call on internal functions here?

    https://coverage.readthedocs.io/en/coverage-4.3.4/excluding.html

  2. changed the title [-]TESTS: Add tests for game_theory/lemke_howson.py[/-] [+]TEST: Add tests for game_theory/lemke_howson.py[/+] on Apr 12, 2017
  3. oyamad commented on Apr 12, 2017

    @oyamad
    Member

    @mmcky Thanks for opening these issues on testing.

    The decrease in the coverage value is in fact not because of the privateness, but because jitted functions with nopython=True are not "covered"; see #144 (comment).

    But yes, fine with me to exclude private functions that are jitted with nopython=True.

  4. mmcky commented on Apr 12, 2017

    @mmcky
    ContributorAuthor

    Thanks @oyamad. I have pushed a branch that updates .coveragerc to skip @jit functions in the coverage statistics. This regex approach moves lemke_howson.py to 88+%

    Perhaps I should fine tune from @jit to @jit(.*nopython=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions