You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
TEST: Add tests for game_theory/lemke_howson.py #302
This has a similar issue to #300. Coverage is driven by internal private functions. As long as all internal functions are testing through lemke_howson() calls we should probably add # pragma: no cover to internal functions to fix the coverage statistics.
@mmcky Thanks for opening these issues on testing.
The decrease in the coverage value is in fact not because of the privateness, but because jitted functions with nopython=True are not "covered"; see #144 (comment).
But yes, fine with me to exclude private functions that are jitted with nopython=True.
Thanks @oyamad. I have pushed a branch that updates .coveragerc to skip @jit functions in the coverage statistics. This regex approach moves lemke_howson.py to 88+%
Perhaps I should fine tune from @jit to @jit(.*nopython=True)
Activity
mmcky commentedon Apr 12, 2017
@oyamad do you agree with adding the no cover call on internal functions here?
https://coverage.readthedocs.io/en/coverage-4.3.4/excluding.html
[-]TESTS: Add tests for game_theory/lemke_howson.py[/-][+]TEST: Add tests for game_theory/lemke_howson.py[/+]oyamad commentedon Apr 12, 2017
@mmcky Thanks for opening these issues on testing.
The decrease in the coverage value is in fact not because of the privateness, but because jitted functions with
nopython=Trueare not "covered"; see #144 (comment).But yes, fine with me to exclude private functions that are jitted with
nopython=True.mmcky commentedon Apr 12, 2017
Thanks @oyamad. I have pushed a branch that updates
.coveragercto skip@jitfunctions in the coverage statistics. This regex approach moveslemke_howson.pyto 88+%Perhaps I should fine tune from
@jitto@jit(.*nopython=True)