Skip to content

Test lemke howson exceptions - #323

Merged
mmcky merged 2 commits into
QuantEcon:masterfrom
QBatista:test-lemke_howson-exceptions
Aug 17, 2017
Merged

mmcky merged 2 commits into
QuantEcon:masterfrom
QBatista:test-lemke_howson-exceptions

Conversation

@QBatista

@QBatista QBatista commented Aug 9, 2017

Copy link
Copy Markdown
Member

Added tests for exceptions to lemke_howson.py and raise type error when init_pivot type is not an integer instance.

Fix #302

@coveralls

coveralls commented Aug 9, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.4%) to 92.631% when pulling b24128d on QBatista:test-lemke_howson-exceptions into 64d964c on QuantEcon:master.

@oyamad oyamad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@mmcky

mmcky commented Aug 9, 2017 •

Copy link
Copy Markdown
Contributor

thanks for the PR @QBatista and for the review @oyamad.
I will leave this PR open for one more day for comment and then will merge.

It appears that travis is in fact green and passing but the web integration isn't updating.

@mmcky

mmcky commented Aug 17, 2017

Copy link
Copy Markdown
Contributor

I reset travis and now showing green so will merge. Thanks again @QBatista and @oyamad

@mmcky
mmcky merged commit 188e5ba into QuantEcon:master Aug 17, 2017
@QBatista
QBatista deleted the test-lemke_howson-exceptions branch September 23, 2017 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants