Repository navigation
Add initialize_communication_on_configure to open port - #119
Open
Michi-Tsubaki wants to merge 1 commit into
Open
Michi-Tsubaki wants to merge 1 commit into
Michi-Tsubaki wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR is needed?
The port is opened and the Dynamixels are initialized in
on_init().As a result:
controller_managerfails to load the component if the motors are off or the U2D2 is unplugged at startup.cleanupdoes not release the port, andconfiguredoes not reconnect. Recovering from a power cycle requires restartingcontroller_manager.ros2_control expects communication to be set up in
on_configure().Changes
initialize_communication_on_configure(defaultfalse). When it istrue, the port is opened and the Dynamixels are initialized inon_configure()instead ofon_init().on_init()so that the handlers are built from the URDF without communication. The existing communication code moves unchanged intoInitDxlCommunication().on_configure()(init),on_cleanup()(close port) andon_shutdown()(torque off and close port).Minimal Example to show advantage
Backward Compatibility
false, so existing URDFs behave as before. No existing public API is removed.cleanupnow closes the port, and the nextconfigurereinitializes the Dynamixels. Previously both were no-ops.reboot_dxlno longer rebuilds the handlers. Rebuilding them invalidated the pointers already exported to ros2_control.