Skip to content

Unhide login button, tidy code, and write tests#56

Merged
loiswells97 merged 12 commits intomainfrom
issues/50-Unhide_login_button_tidy_code_and_write_tests
Feb 24, 2022
Merged

Unhide login button, tidy code, and write tests#56
loiswells97 merged 12 commits intomainfrom
issues/50-Unhide_login_button_tidy_code_and_write_tests

Conversation

@create-issue-branch
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Feb 22, 2022 •
edited by loiswells97
Loading

What's Changed?

  • Removed LOGIN_ENABLED environment variable
  • Added tests for Login and Header components

closes #50

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 22, 2022

  • CircleCI build #150
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 22, 2022

  • CircleCI build #151
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 22, 2022

  • CircleCI build #152
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 22, 2022

  • CircleCI build #153
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 22, 2022

  • CircleCI build #154
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 23, 2022

  • CircleCI build #155
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 23, 2022

  • CircleCI build #157
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 23, 2022

  • CircleCI build #158
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 23, 2022

  • CircleCI build #159
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 23, 2022

  • CircleCI build #163
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 23, 2022

  • CircleCI build #164
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 23, 2022

  • CircleCI build #165
  • Test coverage: 47%

@loiswells97 loiswells97 marked this pull request as ready for review February 23, 2022 11:28
@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 24, 2022

  • CircleCI build #167
  • Test coverage: 47%

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Feb 24, 2022

  • CircleCI build #170
  • Test coverage: 47%

ArayB
ArayB approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@ArayB ArayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loiswells97 loiswells97 merged commit 8bf8887 into main Feb 24, 2022
@sHtev sHtev deleted the issues/50-Unhide_login_button_tidy_code_and_write_tests branch May 12, 2022 08:42
floehopper added a commit that referenced this pull request May 9, 2024
@floehopper
Remove unused REACT_APP_LOGIN_ENABLED env var
e9e2dc6 
This was originally added in [1]. The functionality that relied on it
was then removed in [2] as part of #56, so I think it's safe to remove
it now and reduce any potential confusion about its existence.

[1]: 60e7b5c
[2]: 49c9fa6
@floehopper floehopper mentioned this pull request May 9, 2024
Merged
floehopper added a commit that referenced this pull request May 9, 2024
@floehopper
Remove unused REACT_APP_LOGIN_ENABLED env var
5738e3d 
This was originally added in [1]. The functionality that relied on it
was then removed in [2] as part of #56, so I think it's safe to remove
it now and reduce any potential confusion about its existence.

[1]: 60e7b5c
[2]: 49c9fa6
floehopper added a commit that referenced this pull request May 10, 2024
@floehopper
Remove unused REACT_APP_LOGIN_ENABLED env var (#1006)
2df8a97 
This was originally added in [this commit][1]. The functionality that
relied on it was then removed in [this commit][2] as part of #56, so I
think it's safe to remove it now and reduce any potential confusion
about its existence.

[1]:
60e7b5c
[2]:
49c9fa6
sra405 pushed a commit that referenced this pull request May 28, 2024
@floehopper
Remove unused REACT_APP_LOGIN_ENABLED env var
80ccce5 
This was originally added in [1]. The functionality that relied on it
was then removed in [2] as part of #56, so I think it's safe to remove
it now and reduce any potential confusion about its existence.

c.f. #1006

[1]: 60e7b5c
[2]: 49c9fa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ArayB ArayB ArayB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unhide login button, tidy code, and write tests

3 participants

@raspberrypigithubbot @ArayB @loiswells97