Skip to content

Remove unused REACT_APP_LOGIN_ENABLED env var#1006

Merged
floehopper merged 1 commit intomainfrom
remove-unused-react-app-login-enabled-env-var
May 10, 2024
Merged

Remove unused REACT_APP_LOGIN_ENABLED env var#1006
floehopper merged 1 commit intomainfrom
remove-unused-react-app-login-enabled-env-var

Conversation

@floehopper
Copy link
Contributor

This was originally added in this commit. The functionality that relied on it was then removed in this commit as part of #56, so I think it's safe to remove it now and reduce any potential confusion about its existence.

@github-actions
Copy link

github-actions bot commented May 9, 2024

This was originally added in [1]. The functionality that relied on it
was then removed in [2] as part of #56, so I think it's safe to remove
it now and reduce any potential confusion about its existence.

[1]: 60e7b5c
[2]: 49c9fa6
@github-actions
Copy link

github-actions bot commented May 9, 2024

@floehopper floehopper merged commit 2df8a97 into main May 10, 2024
@floehopper floehopper deleted the remove-unused-react-app-login-enabled-env-var branch May 10, 2024 07:45
@floehopper floehopper mentioned this pull request Jun 3, 2024
floehopper added a commit that referenced this pull request Jun 4, 2024
### Added

- Add `project_name_editable` attribute to web component (#1009)
- Fires custom event when the theme changes (#1015)
- Add `output_only` attribute to web component (#1019 & originally #782)
- Add `assets_identifier` attribute to web component (#1019 & originally
#901)
- Enhance `code` attribute on web component to override project main
component content (#1019 & originally #901)
- Add `runCode`, `stopCode` & `rerunCode` methods to web component
(#1019 & originally #899)
- Send error details in "editor-runCompleted" event (#1019 & originally
#915)
- Return error details to web component (#1019 & originally #915)
- Add `output_panels` attribute to web component (#1019 & originally
#909)

### Changed

- Remove unused `/embedded/projects/:identifier` route (#1013)

### Fixed

- Remove unused `REACT_APP_LOGIN_ENABLED` env var (#1006)
- Fix infinite remix loop when `BYPASS_AUTH` set in `editor-api` (#1007)
- Fixes for docker-compose.yml (#1008)
- Fix deprecation warnings in GitHub Actions (#1011)
- Removed unused `isEmbedded` param from `useProject` call in
`EmbeddedViewer` (#1016)
- Improvements to Cypress specs in CI (#1017)
- Fix warnings and verbose output when starting Webpack Dev Server
(#1018)
- Add e2e spec for project remix behaviour in web component (#1020)
- Fix initial value of `user` in `WebComponentLoader` (#1021)
- Make `authKey` in e2e web component spec more realistic (#1022)
- Remove unused `ComponentStore` (#1023)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants