Specify code output panel(s) in web component#909
Merged
loiswells97 merged 12 commits intooutput-only-wcfrom Feb 2, 2024
Merged
Specify code output panel(s) in web component#909loiswells97 merged 12 commits intooutput-only-wcfrom
loiswells97 merged 12 commits intooutput-only-wcfrom
Conversation
create-issue-branch
bot
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
|
|
…el_s_in_web_component
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
|
…el_s_in_web_component
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
|
danhalson
reviewed
Feb 1, 2024
Contributor
danhalson
left a comment
danhalson
left a comment
There was a problem hiding this comment.
Looks great, just the one suggestion that I think help make things easier to read / more manageable?
| <div className="output-panel output-panel--visual"> | ||
| {hasVisualOutput && showVisualOutput && ( | ||
| <div | ||
| className={`output-panel output-panel--visual${ |
Contributor
There was a problem hiding this comment.
the classnames package (which we're using elsewhere) offers a nice and easy to read interface for doing this, might be worth taking a look :)
Contributor
There was a problem hiding this comment.
Ah yes, okay, I'll take a look - thanks Dan 👍
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
…el_s_in_web_component
|
loiswells97
temporarily deployed
to
previews/issues/906-Specify_code_output_panel_s_in_web_component
GitHub Actions
Inactive
|
sra405
reviewed
Feb 1, 2024
Comment on lines
+450
to
+452
| {!hasVisualOutput && !isEmbedded && isMobile ? ( | ||
| <RunnerControls skinny /> | ||
| ) : null} |
Contributor
There was a problem hiding this comment.
⛏️ I'm sure I've tried this before but it might not work... can we get rid of this null?
Suggested change
| {!hasVisualOutput && !isEmbedded && isMobile ? ( | |
| <RunnerControls skinny /> | |
| ) : null} | |
| {!hasVisualOutput && !isEmbedded && isMobile && ( | |
| <RunnerControls skinny /> | |
| )} |
|
loiswells97
deleted the
issues/906-Specify_code_output_panel_s_in_web_component
branch
floehopper
pushed a commit
that referenced
this pull request
May 20, 2024
floehopper
pushed a commit
that referenced
this pull request
May 20, 2024
floehopper
pushed a commit
that referenced
this pull request
May 20, 2024
floehopper
pushed a commit
that referenced
this pull request
May 20, 2024
floehopper
pushed a commit
that referenced
this pull request
May 22, 2024
floehopper
pushed a commit
that referenced
this pull request
May 22, 2024
floehopper
pushed a commit
that referenced
this pull request
May 28, 2024
floehopper
pushed a commit
that referenced
this pull request
May 29, 2024
floehopper
pushed a commit
that referenced
this pull request
May 30, 2024
floehopper
pushed a commit
that referenced
this pull request
May 30, 2024
floehopper
pushed a commit
that referenced
this pull request
May 30, 2024
floehopper
pushed a commit
that referenced
this pull request
May 30, 2024
floehopper
pushed a commit
that referenced
this pull request
May 31, 2024
Based on #909. The new `output_panels` attribute on the web component allows specific panels to be selected when the `output-only` web component attribute is set to `true`. Currently there are two panels: the "text" panel and the "visual" panel. You can select either or both. Note that this functionality has only currently been implemented for the `PythonRunner` and not the `PyodideRunner` or the `HtmlRunner`. The motivation for this change is to support the Block-to-Text app [1]. The exercise in the alpha version of this app displays just the "visual" panel [2]. I've added a couple of unit tests in `PythonRunner.test.js` to test the new behaviour. And I plan to add an e2e spec in a subsequent commit which will test all the new attributes on the web component. [1]: https://github.com/RaspberryPiFoundation/block-to-text-alpha/ [2]: https://github.com/RaspberryPiFoundation/block-to-text-alpha/blob/d16a8ecc1d3da202363fb16db31f4bf93f46aa04/src/components/Editor.js#L19
Merged
floehopper
added a commit
that referenced
this pull request
Jun 4, 2024
### Added - Add `project_name_editable` attribute to web component (#1009) - Fires custom event when the theme changes (#1015) - Add `output_only` attribute to web component (#1019 & originally #782) - Add `assets_identifier` attribute to web component (#1019 & originally #901) - Enhance `code` attribute on web component to override project main component content (#1019 & originally #901) - Add `runCode`, `stopCode` & `rerunCode` methods to web component (#1019 & originally #899) - Send error details in "editor-runCompleted" event (#1019 & originally #915) - Return error details to web component (#1019 & originally #915) - Add `output_panels` attribute to web component (#1019 & originally #909) ### Changed - Remove unused `/embedded/projects/:identifier` route (#1013) ### Fixed - Remove unused `REACT_APP_LOGIN_ENABLED` env var (#1006) - Fix infinite remix loop when `BYPASS_AUTH` set in `editor-api` (#1007) - Fixes for docker-compose.yml (#1008) - Fix deprecation warnings in GitHub Actions (#1011) - Removed unused `isEmbedded` param from `useProject` call in `EmbeddedViewer` (#1016) - Improvements to Cypress specs in CI (#1017) - Fix warnings and verbose output when starting Webpack Dev Server (#1018) - Add e2e spec for project remix behaviour in web component (#1020) - Fix initial value of `user` in `WebComponentLoader` (#1021) - Make `authKey` in e2e web component spec more realistic (#1022) - Remove unused `ComponentStore` (#1023)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #906