Merged
Conversation
loiswells97
temporarily deployed
to
previews/web-component-run-method
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/web-component-run-method
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/web-component-run-method
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/web-component-run-method
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/web-component-run-method
GitHub Actions
Inactive
|
|
sra405
approved these changes
Jan 30, 2024
Contributor
sra405
left a comment
sra405
left a comment
There was a problem hiding this comment.
👍 lgtm - again loving exposing some methods through the web component!!
floehopper
pushed a commit
that referenced
this pull request
May 30, 2024
Based on [1] & #899. The motivation for this change is to support the Block-to-Text app [2]. This mainly adds the `runCode`, `stopCode`, & `rerunCode` methods to the web component, but it also adds a check on the `webComponent` boolean state in `Output` to determine whether or not to render the `RunBar`. I don't really understand why this is needed, but having chatted to @loiswells97 we've got a nagging feeling there's a use case that does need it, so I'm going to leave it in plae for now. I've added a unit test to illustate the behaviour. I plan to add an e2e spec in a subsequent commit which will test the new methods on the web component. [1]: f9086a8 [2]: https://github.com/RaspberryPiFoundation/block-to-text-alpha/
floehopper
pushed a commit
that referenced
this pull request
May 30, 2024
Based on [1] & #899. The motivation for this change is to support the Block-to-Text app [2]. This mainly adds the `runCode`, `stopCode`, & `rerunCode` methods to the web component, but it also adds a check on the `webComponent` boolean state in `Output` to determine whether or not to render the `RunBar`. I don't really understand why this is needed, but having chatted to @loiswells97 we've got a nagging feeling there's a use case that does need it, so I'm going to leave it in plae for now. I've added a unit test to illustate the behaviour. I plan to add an e2e spec in a subsequent commit which will test the new methods on the web component. [1]: f9086a8 [2]: https://github.com/RaspberryPiFoundation/block-to-text-alpha/
floehopper
pushed a commit
that referenced
this pull request
May 31, 2024
Based on [1] & #899. The motivation for this change is to support the Block-to-Text app [2] which uses the `rerunCode` method in its exercise to allow the user to run the code from the button outside the web component [3]. This mainly adds the `runCode`, `stopCode`, & `rerunCode` methods to the web component, but it also adds a check on the `webComponent` boolean state in `Output` to determine whether or not to render the `RunBar`. I don't really understand why this is needed, but having chatted to @loiswells97 we've got a nagging feeling there's a use case that does need it, so I'm going to leave it in plae for now. I've added a unit test to illustrate the new behaviour. I plan to add an e2e spec in a subsequent commit which will test the new methods on the web component. [1]: f9086a8 [2]: https://github.com/RaspberryPiFoundation/block-to-text-alpha/ [3]: https://github.com/RaspberryPiFoundation/block-to-text-alpha/blob/d16a8ecc1d3da202363fb16db31f4bf93f46aa04/src/components/Step.js#L87
Merged
floehopper
added a commit
that referenced
this pull request
Jun 4, 2024
### Added - Add `project_name_editable` attribute to web component (#1009) - Fires custom event when the theme changes (#1015) - Add `output_only` attribute to web component (#1019 & originally #782) - Add `assets_identifier` attribute to web component (#1019 & originally #901) - Enhance `code` attribute on web component to override project main component content (#1019 & originally #901) - Add `runCode`, `stopCode` & `rerunCode` methods to web component (#1019 & originally #899) - Send error details in "editor-runCompleted" event (#1019 & originally #915) - Return error details to web component (#1019 & originally #915) - Add `output_panels` attribute to web component (#1019 & originally #909) ### Changed - Remove unused `/embedded/projects/:identifier` route (#1013) ### Fixed - Remove unused `REACT_APP_LOGIN_ENABLED` env var (#1006) - Fix infinite remix loop when `BYPASS_AUTH` set in `editor-api` (#1007) - Fixes for docker-compose.yml (#1008) - Fix deprecation warnings in GitHub Actions (#1011) - Removed unused `isEmbedded` param from `useProject` call in `EmbeddedViewer` (#1016) - Improvements to Cypress specs in CI (#1017) - Fix warnings and verbose output when starting Webpack Dev Server (#1018) - Add e2e spec for project remix behaviour in web component (#1020) - Fix initial value of `user` in `WebComponentLoader` (#1021) - Make `authKey` in e2e web component spec more realistic (#1022) - Remove unused `ComponentStore` (#1023)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.