update dependencies and SDL API to current versions#1496
Closed
osimarr wants to merge 3 commits intoRust-SDL2:masterfrom
Closed
update dependencies and SDL API to current versions#1496osimarr wants to merge 3 commits intoRust-SDL2:masterfrom
osimarr wants to merge 3 commits intoRust-SDL2:masterfrom
Conversation
Signed-off-by: David Cohen <dacohen@pm.me>
update new events and add supoport to SDL_HasWindowSurface() and SDL_DestroyWindowSurface()
Some (dev-)dependencies are outdated. Let's bring them to current version and do the proper API update in the code.
antonilol
reviewed
Oct 27, 2025
Contributor
antonilol
left a comment
antonilol
left a comment
There was a problem hiding this comment.
This looks okay apart from that reviewing thousands of lines in sdl_bindings.rs would be a waste of time, I would rather have that file be deterministically generated and perhaps checked in the CI?
antonilol
added a commit
to antonilol/rust-sdl2
that referenced
this pull request
Oct 27, 2025
antonilol
added a commit
to antonilol/rust-sdl2
that referenced
this pull request
Oct 29, 2025
Merged
3 tasks
Contributor
|
Changes from this PR will be merged with #1506 |
antonilol
added a commit
that referenced
this pull request
Nov 10, 2025
…dl and dependencies (#1506) * update bindgen and pin version, remove (hopefully all) platform dependent unused stuff from sdl_bindings.rs * update SDL to 2.32.10 release notes: https://github.com/libsdl-org/SDL/releases/tag/release-2.32.10 * take all changes from #1496 except changes to bindings * fmt * update bitflags and lazy_static * give all bitflags types the same useful set of derives mostly adds Default * add changelog entry * remove TODO and unpin bindgen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.