Skip to content

remove platform dependent unused stuff from sdl_bindings.rs, update sdl and dependencies#1506

Merged
antonilol merged 8 commits intoRust-SDL2:masterfrom
antonilol:clean-bindings
Nov 10, 2025
Merged

remove platform dependent unused stuff from sdl_bindings.rs, update sdl and dependencies#1506
antonilol merged 8 commits intoRust-SDL2:masterfrom
antonilol:clean-bindings

Conversation

@antonilol
Copy link
Copy Markdown
Contributor

@antonilol antonilol commented Oct 27, 2025

  • update sdl2
  • remove platform dependent unused stuff from sdl_bindings.rs
  • update bindgen
  • fix ci? -> later pr
  • check generated sdl_bindings.rs in ci? -> later pr or maybe not

closes #1496
closes #1500

@antonilol antonilol changed the title remove platform dependent unused stuff from sdl_bindings.rs remove platform dependent unused stuff from sdl_bindings.rs, update sdl and dependencies Oct 27, 2025
@antonilol antonilol mentioned this pull request Oct 28, 2025
@jagprog5 jagprog5 requested a review from Cobrand October 28, 2025 16:38
@antonilol antonilol marked this pull request as ready for review October 29, 2025 09:26
@antonilol antonilol requested a review from jagprog5 October 29, 2025 09:48
@antonilol
Copy link
Copy Markdown
Contributor Author

I set it to ready to review earlier, but now it is actually ready.

I also have a suspicion as to why the CI fails, at least only the windows case (not the vcpkg case):
Some X11 event structures are checked by bindgen on windows, from bindings generated on linux. This did not happen before because bindgen used to generate "runtime tests" using #[test] fn test() {}, but now does "compile time tests" that make the compilation fail if the layout of the structures is not expected. I guess a pointer width difference makes it fail?

@antonilol
Copy link
Copy Markdown
Contributor Author

56a65ed is a small otherwise unrelated change I added (I need Default for keyboard::Mod). It is documented in the changelog as well.

@antonilol antonilol mentioned this pull request Oct 29, 2025
2 tasks
@jagprog5
Copy link
Copy Markdown
Contributor

looks fine to me. @Cobrand

@antonilol antonilol merged commit adeb978 into Rust-SDL2:master Nov 10, 2025
11 of 17 checks passed
@antonilol antonilol deleted the clean-bindings branch November 10, 2025 21:42
@iddm
Copy link
Copy Markdown
Contributor

iddm commented Dec 8, 2025

Hey guys! Thank you for your great work! Can you also release this with a minor version update (0.38.x)?

@antonilol
Copy link
Copy Markdown
Contributor Author

I'd rather fix the build issue than backport this, and then have these changes in 0.39. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segfault when opening (and closing) the controller more than once

3 participants