Skip to content

Remove unnecessary extern from C function declarations#283

Merged
ChrisThrasher merged 1 commit intomasterfrom
extern_c
Sep 1, 2024
Merged

Remove unnecessary extern from C function declarations#283
ChrisThrasher merged 1 commit intomasterfrom
extern_c

Conversation

@ChrisThrasher
Copy link
Copy Markdown
Member

No description provided.

@ChrisThrasher ChrisThrasher merged commit dfaebc6 into master Sep 1, 2024
@ChrisThrasher ChrisThrasher deleted the extern_c branch September 1, 2024 19:52
@eXpl0it3r eXpl0it3r added this to the 3.0 milestone Sep 3, 2024
@ChrisThrasher
Copy link
Copy Markdown
Member Author

ChrisThrasher commented Sep 5, 2024

It's true that extern on C function declarations is unnecessary. However, these macros are also used for global variables and I think we do need to mark those as extern which currently is not happening.

EDIT: See #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants