Revert "Remove unnecessary extern from C function declarations"#308
Merged
ChrisThrasher merged 1 commit intomasterfrom Sep 5, 2024
Merged
Revert "Remove unnecessary extern from C function declarations"#308ChrisThrasher merged 1 commit intomasterfrom
extern from C function declarations"#308ChrisThrasher merged 1 commit intomasterfrom
Conversation
This reverts commit dfaebc6.
eXpl0it3r
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dfaebc6.
We still need to make sure
externis applied to the variables we export from the interface as is the case withsfColorconstants, for example. For whatever reason this doesn't cause compilation to fail anywhere so I can't demonstrate a failure due to the lack ofexternbut for the sake of caution I'm reverting my previous commit.