Fix podcast total duration in HiddenAudioPlayer on Firefox #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox doesn't do the audio element's duration correctly, causing the total duration to appear as NaN.
Owner
|
Thanks for the pull request :). Really appreciated as I don't really use Firefox so I would never call this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firefox doesn't load the entire file before playing resulting in the duration of the audio element changing until playback is near the end of the file, but the onLoadedMetadata event doesn't get triggered again. This results in the progress bar just displaying infinity and NaN on Firefox.
This pr adds a fallback, if the total duration is NaN a request is sent to
/podcast/episode/{id}to retrieve the total duration and updates the audio metadata with the correct duration.Linked Issues
None