Skip to content

Fix podcast total duration in HiddenAudioPlayer on Firefox #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
Mar 27, 2024
Merged

Fix podcast total duration in HiddenAudioPlayer on Firefox #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ui/src/components/HiddenAudioPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const HiddenAudioPlayer: FC<HiddenAudioPlayerProps> = ({ refItem, setAudi
.then((response: AxiosResponse<PodcastWatchedModel>) => {
setCurrentPodcastEpisode({
...podcastEpisode,
time: response.data.watchedTime
time: response.data.position
})
refItem.current!.currentTime = podcastEpisode.time!
})
Expand Down Expand Up @@ -61,6 +61,21 @@ export const HiddenAudioPlayer: FC<HiddenAudioPlayerProps> = ({ refItem, setAudi
duration: e.currentTarget.duration,
percentage: 0
})

if (isNaN(e.currentTarget.duration)) {
// Need alternative method of getting duration
// Firefox doesn't load the entire file before playing
// causing a changing duration, but the onLoadedMetadata event
// is only called once rendering the progressbar useless
axios.get('/podcast/episode/' + podcastEpisode.episode_id)
.then((response: AxiosResponse<PodcastWatchedModel>) => {
setMetadata({
currentTime: e.currentTarget.currentTime,
duration: response.data.total,
percentage: 0
})
})
}
}}
/>
)
Expand Down