Skip to content

Use API-based commits for verification#1002

Merged
AbdulRahmanAlHamali merged 16 commits into
mainfrom
abdullah/github-actions-bot-commit-signing
Jan 30, 2026
Merged

Use API-based commits for verification#1002
AbdulRahmanAlHamali merged 16 commits into
mainfrom
abdullah/github-actions-bot-commit-signing

Conversation

@Abuudiii

Copy link
Copy Markdown
Contributor

No description provided.

@Abuudiii Abuudiii closed this Jan 27, 2026
@Abuudiii Abuudiii reopened this Jan 27, 2026
with:
fetch-depth: 30
ref: main
fetch-depth: 0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we change this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog script needs git log v{last_version}..HEAD to work. With depth 30, if there are more than 30 commits since the last release, the tag won't be reachable and the command fails. fetch-depth: 0 makes sure we always have access to the previous version tag.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh gotcha

Comment thread .github/workflows/create-release.yml Outdated
Comment thread .github/workflows/create-release.yml Outdated
…d commit steps with the 'create-pull-request' action, streamlining the version bump process and enhancing automation.
…es and enhance readability of the release title and body.
with:
fetch-depth: 30
ref: main
fetch-depth: 0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh gotcha

@AbdulRahmanAlHamali AbdulRahmanAlHamali merged commit 5d7dc19 into main Jan 30, 2026
70 checks passed
@AbdulRahmanAlHamali AbdulRahmanAlHamali deleted the abdullah/github-actions-bot-commit-signing branch January 30, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants