Skip to content

Use API-based commits for verification #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbdulRahmanAlHamali merged 16 commits into from
Jan 30, 2026
Merged

Use API-based commits for verification #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0587838
Use API-based commits for verification
Abuudiii Jan 26, 2026
8638442
Update release workflow to use simplified commit message formatting a…
Abuudiii Jan 26, 2026
536a9e5
Update GitHub Actions workflow to set fetch-depth to 0 and specify ma…
Abuudiii Jan 26, 2026
d14370f
Add sign-commits option to release workflow for enhanced commit verif…
Abuudiii Jan 26, 2026
753840c
Refactor release workflow to use GitHub CLI for pull request creation…
Abuudiii Jan 26, 2026
e8d6606
Enhance release workflow by adding a step to create and push a new br…
Abuudiii Jan 27, 2026
3f0f720
Update create-release workflow to use the latest version of the signe…
Abuudiii Jan 27, 2026
c3075b2
Refactor create-release workflow to utilize GitHub Script for committ…
Abuudiii Jan 27, 2026
69845a8
Refactor create-release workflow to improve readability of git status…
Abuudiii Jan 27, 2026
a154004
Add CLA check to workflows for enhanced contribution verification
Abuudiii Jan 27, 2026
a05401e
Add permissions for actions and pull-requests in CLA check workflow t…
Abuudiii Jan 27, 2026
f2d31b5
Update CLA workflow trigger from 'workflow_call' to 'workflow_dispatc…
Abuudiii Jan 27, 2026
82e7c5f
Refactor CLA and create-release workflows to enhance security by usin…
Abuudiii Jan 29, 2026
3b2521a
Merge branch 'main' into abdullah/github-actions-bot-commit-signing
Abuudiii Jan 29, 2026
be7a37f
Refactor create-release workflow to replace manual branch creation an…
Abuudiii Jan 30, 2026
9330a8e
Update create-release workflow to improve formatting of commit messag…
Abuudiii Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/cla.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ jobs:
runs-on: ubuntu-latest
if: |
(github.event.issue.pull_request
&& !github.event.issue.pull_request.merged_at
&& contains(github.event.comment.body, 'signed')
)
&& !github.event.issue.pull_request.merged_at
&& contains(github.event.comment.body, 'signed'))
|| (github.event.pull_request && !github.event.pull_request.merged)
steps:
- uses: Shopify/shopify-cla-action@v1
Expand Down
67 changes: 29 additions & 38 deletions .github/workflows/create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ jobs:
name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
fetch-depth: 30
ref: main
fetch-depth: 0

@AbdulRahmanAlHamali AbdulRahmanAlHamali Jan 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we change this?

@Abuudiii Abuudiii Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog script needs git log v{last_version}..HEAD to work. With depth 30, if there are more than 30 commits since the last release, the tag won't be reachable and the command fails. fetch-depth: 0 makes sure we always have access to the previous version tag.

@AbdulRahmanAlHamali AbdulRahmanAlHamali Jan 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh gotcha

fetch-tags: true
-
name: Set up Ruby
Expand Down Expand Up @@ -92,40 +93,30 @@ jobs:
"${{ needs.read-version.outputs.current_version }}"
-
name: Create pull request
env:
GH_TOKEN: ${{ github.token }}
run: |
new_version="${{ needs.read-version.outputs.new_version }}"
branch_name="release/v$new_version"

# Configure git
git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
git config --local user.name "github-actions[bot]"

# Create and checkout new branch
git checkout -b "$branch_name"

# Add and commit changes
git add lib/semian/version.rb Gemfile.lock CHANGELOG.md
git commit -m "Bump version to $new_version" -m "Triggered by @${{ github.actor }}"

# Push the branch
git push origin "$branch_name"

# Create pull request
gh pr create \
--title "Release v$new_version" \
--body "Automated version bump to $new_version

This PR includes:
- Updated version in \`lib/semian/version.rb\`
- Updated \`Gemfile.lock\`
- Updated \`CHANGELOG.md\`

**Release type:** ${{ github.event.inputs.release_type }}
**Triggered by:** @${{ github.actor }}

After merging this PR, the **Publish Release** workflow will automatically \
build the gem and publish it to GitHub releases." \
--base main \
--head "$branch_name"
uses: peter-evans/create-pull-request@v7
with:
token: ${{ secrets.SHOPIFY_GH_ACCESS_TOKEN }}
branch: release/v${{ needs.read-version.outputs.new_version }}
base: main
title: Release v${{ needs.read-version.outputs.new_version }}
body: |
Automated version bump to ${{ needs.read-version.outputs.new_version }}

This PR includes:
- Updated version in `lib/semian/version.rb`
- Updated `Gemfile.lock`
- Updated `CHANGELOG.md`

**Release type:** ${{ github.event.inputs.release_type }}
**Triggered by:** @${{ github.actor }}

After merging this PR, the **Publish Release** workflow will automatically
build the gem and publish it to GitHub releases.
commit-message: Bump version to ${{ needs.read-version.outputs.new_version }}
committer: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sign-commits: true
add-paths: |
lib/semian/version.rb
Gemfile.lock
CHANGELOG.md