This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Make ipv6-only the default and remove the ability to configure it.#93
Merged
Conversation
Contributor
|
This is a breaking wit change, but I've checked in with various stakeholders and we all agree that this both the right change to make for the spec, and a very minor breakage to accommodate in all implementations we know of. The alternative to making this change to remove the setter and getter is to document that the getter always returns true and the setter traps when given false, which doesnt seem like an ideal outcome. Therefore, I'd like to land this change ASAP and then cut new RCs. |
This was referenced Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the spec doesn't mention anything about the default value of
ipv6-only. This PR changes that to betrue, because that's universally supported.This requires a change in wasmtime.
JCO should be good to go as libuv does this by default.
Additionally, this PR removes the ability to enable dual-stack sockets (
ipv6-only==false) altogether as the OS-support is questionable:This removal does not preclude us from adding an advanced option in the future to opt back in to this.