wasi implementations: use rc-2024-01-16 for sockets, cli, http#7781
Merged
Conversation
* a v6_client.blocking_connect(net, v4_listener) will always fail with INVAL right away. * eliminate the paths where a v6 client is allowed to connect to v4. * eliminate the udp_dual_stack_conversation from udp_sample_application
badeend
suggested changes
Jan 16, 2024
Member
badeend
left a comment
badeend
left a comment
There was a problem hiding this comment.
I have one remark. Other than that: LGMT!
| // Connecting to an IPv4 address on an IPv6 socket should fail: | ||
| assert!(matches!( | ||
| v6_client.blocking_connect(net, v6_listener_addr), | ||
| v6_client.blocking_connect(net, v4_listener_addr), |
Member
There was a problem hiding this comment.
This should attempt to connect to v6_listener_addr which was a IPv4-mapped-IPv6 address. The way you rewrote it, this call doesn't actually test the change.
|
|
||
| // Connecting to an IPv4 address on an IPv6 socket should fail: | ||
| assert!(matches!( | ||
| v6_client.stream(Some(v4_server_addr)), |
sunfishcode
approved these changes
Jan 16, 2024
pchickey
pushed a commit
that referenced
this pull request
Jan 17, 2024
* wasi: pull in contents of wasi-sockets, wasi-http, and wasi-cli 0.2.0-rc-2024-01-16 * command-extended and test worlds: use rc-2024-01-16 * sockets implementation: v6only is now mandatory * adapter: cli imports and exports are from rc-2024-01-16 now * eliminate ipv6-only methods and tests * a v6_client.blocking_connect(net, v4_listener) will always fail with INVAL right away. * eliminate the paths where a v6 client is allowed to connect to v4. * eliminate the udp_dual_stack_conversation from udp_sample_application * component-basic: update wasi:cli version * wasi-http: sync wit directory * wasi-http: fix import version * code review from dave * test both ipv4 address on v6 socket, and ipv6-mapped-ipv4 on v6 socket, both fail
alexcrichton
pushed a commit
that referenced
this pull request
Jan 17, 2024
#7785) * wasi: pull in contents of wasi-sockets, wasi-http, and wasi-cli 0.2.0-rc-2024-01-16 * command-extended and test worlds: use rc-2024-01-16 * sockets implementation: v6only is now mandatory * adapter: cli imports and exports are from rc-2024-01-16 now * eliminate ipv6-only methods and tests * a v6_client.blocking_connect(net, v4_listener) will always fail with INVAL right away. * eliminate the paths where a v6 client is allowed to connect to v4. * eliminate the udp_dual_stack_conversation from udp_sample_application * component-basic: update wasi:cli version * wasi-http: sync wit directory * wasi-http: fix import version * code review from dave * test both ipv4 address on v6 socket, and ipv6-mapped-ipv4 on v6 socket, both fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebAssembly/wasi-sockets#93 eliminates the ipv6-only sockopt getter and setter, and the ability for cross-stack ipv6 to ipv4 connections to take place, so these are bubbled out through the test suites.