Add aiohttp.tracing.TraceRequestHeadersSentParams into the top level file.#8947
Add aiohttp.tracing.TraceRequestHeadersSentParams into the top level file.#8947Dreamsorcerer merged 7 commits intoaio-libs:masterfrom
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8947 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 107 107
Lines 34226 34226
Branches 4058 4058
=======================================
Hits 33637 33637
Misses 416 416
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Dreamsorcerer thanks for cleaning up my mess :^) |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e2437a4 on top of patchback/backports/3.10/e2437a48ec31f830100606a62bb822e44bab1114/pr-8947 Backporting merged PR #8947 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e2437a4 on top of patchback/backports/3.11/e2437a48ec31f830100606a62bb822e44bab1114/pr-8947 Backporting merged PR #8947 into master
🤖 @patchback |
|
I was hoping patchback would sort that one automatically. Could you sort out the backports with the above instructions? |
sure can, 2 moments. |
…file. (aio-libs#8947) (cherry picked from commit e2437a4)
…file. (aio-libs#8947) (cherry picked from commit e2437a4)
|
what branch do i pr my 3.10 changes to? i dont see any backports branch. |
|
ok, i see my eror, i pr'd to the wrong branch 👎 |
|
@Dreamsorcerer would you mind making sure I did everything correct? Having a bit of a panic making sure I didn't mess anything up. |
What do these changes do?
Add aiohttp.tracing.TraceRequestHeadersSentParams into the top level file
Are there changes in behavior for the user?
Typehints change from aiohttp.tracing.TraceRequestHeadersSent to aiohttp.TraceRequestHeadersSent.
Is it a substantial burden for the maintainers to support this?
No.
Related issue number
Fixes #8946
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.