fix: add state to pause existing audio for demo menus, add support fo…#10428
Merged
adamdotdevin merged 1 commit intoanomalyco:devfrom Jan 24, 2026
Conversation
…r keyboard playing sounds
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
xenonwellz
pushed a commit
to xenonwellz/opencode
that referenced
this pull request
Jan 28, 2026
xenonwellz
pushed a commit
to xenonwellz/opencode
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10427
What does this PR do?
This PR fixes an issue where in the desktop app sounds would overlap while hovering over the demo sound menus with the pointer causing a bunch of annoying sounds to overlay.
It also addresses navigating the menus with the keyboard not playing the sounds.
How did you verify your code works?
I tested it myself in the app.
Screen.Recording.2026-01-24.at.12.11.17.PM.mov
NOTE: The above screen recording has sound. When navigating the menus now the sounds don't all immediately overlap since we pause the existing sound and also add a slight delay before playing to prevent more overlap.
Also via you can see when I use the keyboard the sounds are playing