Repository navigation
fix(core): stop polling DigitalOcean routers - #57175
Conversation
There was a problem hiding this comment.
The fix works and looks sound. I ran the #57152 reproduction from source on both checkouts. On the base, the loaded folder republishes provider.updated and model.updated 5 minutes after it loads. With this change, only the pair at load time appears. The existing DigitalOcean plugin tests pass (they cover connecting, switching accounts, falling back to a key credential and disconnecting), and typecheck passes for packages/core.
The check covers both the access token and the router names, so connecting, disconnecting and changes to the router list still trigger a reload.
Public API: unchanged.
No concerns.
Co-authored-by: mradwankhalil <293462981+mradwankhalil@users.noreply.github.com>
e797d22 to
a2a7a3c
Compare
|
Recording a stock-release gap, not asking to reopen. The same-account/same-routers case still fails on v2.2.6 (dc2ffcf): a regression from our local guard, run against stock, gives 24 pass / 2 fail. The failing case is |
Fixes #57152.
The DigitalOcean plugin polled routers every 5 minutes in every loaded location and called
ctx.provider.reload()on every tick, even with no DigitalOcean connection. Each tick republishedprovider.updatedandmodel.updated, and clients refetched both catalogs.This drops the poll. Routers now load at startup and on
Credential.Switched, matching GitHub Copilot and GitLab. Routers changed in the DigitalOcean dashboard mid-session appear after restart or re-auth. The poll-only test assertions are removed.Supersedes #57153 by @mradwankhalil, credited as co-author.
Requested by: @rekram1-node (Aiden Cline via Slack)