Repository navigation
fix(core): refresh DigitalOcean routers while signed in - #58346
Closed
rekram1-node wants to merge 1 commit into
Closed
rekram1-node wants to merge 1 commit into
rekram1-node wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
No blocking problems found. Polling runs only while signed in and stops when you sign out or the token expires. A router added mid-session shows up on the next tick, and an unchanged router list no longer reloads the catalog.
How I checked: I ran a throwaway scenario with a mocked HTTP client and a simulated clock. Signed out, it made no requests. Signed in, it made one request per 5 minutes, and a new router appeared after one tick. Signing in again with a new token and the same routers kept them in the catalog. The existing DigitalOcean tests pass (10/10), and tsc -b for packages/core passes.
Public API: unchanged. This is an internal change to the plugin only.
No concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#57175 stopped the DigitalOcean router poll because it ran in every open folder every 5 minutes, even when signed out, and reloaded the catalog on every tick. Since then, a router created mid-session only shows up after a restart or re-auth.
Change
The refresh is back, every 5 minutes, but only while signed in, and each tick is quiet unless the routers actually changed.
provider.updated.Out of scope
Tested