feat: expose acp thinking variants#9064
Merged
rekram1-node merged 29 commits intoanomalyco:devfrom Jan 29, 2026
Merged
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Collaborator
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
|
thanks! |
Contributor
Author
|
@rekram1-node ready for your re-review! |
Contributor
Author
|
@rekram1-node btw been using and there's no stability problem whatsoever! i have found an another bug on opencode acp though, gonna fix it after this merged |
…king-variants # Conflicts: # packages/app/src/components/prompt-input.tsx
Contributor
Author
|
any update @rekram1-node @adamdotdevin ? |
adolago
added a commit
to adolago/agent-core
that referenced
this pull request
Jan 31, 2026
Apply commit fdd484d from opencode/dev: - Add variant support to ACPSessionState - Add getVariant/setVariant methods to ACPSessionManager - Update setSessionModel to handle variants and return _meta - Update setSessionMode to validate mode exists - Update loadSessionMode/newSession to return variant metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8973 by exposing thinking variants in ACP model selection:
claude-sonnet-4/high) tomodels.availableModelssession/set_modelselections and keeps session variant in sync_meta(modelId,variant,availableVariants) instead of empty object@agentclientprotocol/sdkto 0.13.0How did you verify your code works?
bun run typechecksession/set_modelresponses include correct_meta.opencodewith variant infoScreenshot