Skip to content

fix: restore parameters support when sql passed to SnowflakeHook as str - #16102

Merged
potiuk merged 4 commits into
apache:masterfrom
grassten:snowflake_parameterization
May 27, 2021
Merged

potiuk merged 4 commits into
apache:masterfrom
grassten:snowflake_parameterization

Conversation

@grassten

@grassten grassten commented May 27, 2021 •

Copy link
Copy Markdown
Contributor

In 2.1.0 the SnowflakeHook/Operator dropped support for parameters when passing SQL as a string. This re-enables parameterization and keeps query splitting functionality using split_statements from Snowflake (the same function used within execute_string) and then parameterizes and executes the individual queries.

closes #16068

@boring-cyborg boring-cyborg Bot added area:providers provider:snowflake Issues related to Snowflake provider labels May 27, 2021
@boring-cyborg

boring-cyborg Bot commented May 27, 2021

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr

Copy link
Copy Markdown
Member

Implementation looks good to me, the tests should be merged with parametrize.

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks! Looks great. Thanks for parameterizing the tests!

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 27, 2021
@github-actions

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
potiuk merged commit aeb93f8 into apache:master May 27, 2021
@boring-cyborg

boring-cyborg Bot commented May 27, 2021

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:snowflake Issues related to Snowflake provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snowflake hook doesn't parameterize SQL passed as a string type, causing SnowflakeOperator to fail

3 participants