Remove old UI and webserver by bbovenzi · Pull Request #46942 · apache/airflow

bbovenzi · 2025-02-20T21:27:35Z

Try to strip out as much of the old webserver and UI as possible for AIP-79.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

jedcunningham · 2025-02-20T21:32:40Z

So we don't loose it from the original PR: #protm!

uranusjr · 2025-02-21T05:36:53Z

Now we removed www, FAB is not automatically set up for tests. This is causing problems in FAB provider tests.

jscheffl · 2025-02-21T20:06:56Z

I'm starrting to take a look into failing breeze tests...

potiuk · 2025-02-21T21:07:25Z

I did too @jscheffl -> fixed some more

jscheffl · 2025-02-21T21:08:16Z

I did too @jscheffl -> fixed some more

I was unsure and wated to contact you.... but you fixed what I suspected and wondered why this was the impact.

potiuk · 2025-02-21T21:09:20Z

I was unsure and wated to contact you.... but you fixed what I suspected and wondered why this was the impact.

fab provider is added as amazon's optional dependency -> that triggers the tests transitively

jscheffl · 2025-02-22T19:11:59Z

I was attempting to make some fixes to the pytests failing, but I am missing an idea how the previous mocked app based on appbuilder+Flask can be replicated over. I fear either we need to re-write a lot of tests or we need to add the dependency to FAB provider... which is also not helpful.
A common solution would be great but I am lagging an idea.

potiuk · 2025-02-23T08:52:04Z

I was attempting to make some fixes to the pytests failing, but I am missing an idea how the previous mocked app based on appbuilder+Flask can be replicated over. I fear either we need to re-write a lot of tests or we need to add the dependency to FAB provider... which is also not helpful.
A common solution would be great but I am lagging an idea.

I think it's a matter of adding the right fixture to tests_common so that it can be used with those tests - following the new "fast_api" way of initializing the app, but I also lack a bit of understanding how it is done now without doing a lot of digging

jedcunningham · 2025-02-23T19:16:38Z

@pierrejeambrun @bbovenzi take a look at 6a01eaa - I didn't want to tackle a general "build arbitrary url" helper, so I just did dagrun. Is there something existing for this use case though?

pierrejeambrun · 2025-02-24T13:54:26Z

@pierrejeambrun @bbovenzi take a look at 6a01eaa - I didn't want to tackle a general "build arbitrary url" helper, so I just did dagrun. Is there something existing for this use case though?

Looks nice. I am not aware of anything that can achieve this in the new web stack.

potiuk · 2025-02-24T20:13:24Z

Looking promising !

potiuk · 2025-02-26T22:58:20Z

All good - it should be ✅ hopefully - all remaining things in comments.

bbovenzi · 2025-02-27T01:59:58Z

bugraoz93 · 2025-02-27T03:02:07Z

End of an era, amazing work!

pierrejeambrun · 2025-02-27T10:28:32Z

🎉 🎉

jscheffl · 2025-02-27T19:44:31Z

Wow. I did not expect it gets merged this week :-D Good job!

potiuk · 2025-02-27T21:14:25Z

Beta release today sped up the work :)

…w`. (apache#47060) Relates to apache#46942

Co-authored-by: Ash Berlin-Taylor <ash@apache.org> Co-authored-by: Jed Cunningham <jedcunningham@apache.org> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: vincbeck <vincbeck@amazon.com> Co-authored-by: Jens Scheffler <jscheffl@apache.org> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: vatsrahul1001 <43964496+vatsrahul1001@users.noreply.github.com> Co-authored-by: GPK <gopidesupavan@gmail.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>

After apache#46942 - we should wait for UI not WWW asset compilation in the start-airlfow command.

…47202) After #46942 - we should wait for UI not WWW asset compilation in the start-airlfow command.

shahar1 · 2025-03-01T06:04:58Z

Well done!

…w`. (apache#47060) Relates to apache#46942

Co-authored-by: Ash Berlin-Taylor <ash@apache.org> Co-authored-by: Jed Cunningham <jedcunningham@apache.org> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: vincbeck <vincbeck@amazon.com> Co-authored-by: Jens Scheffler <jscheffl@apache.org> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: vatsrahul1001 <43964496+vatsrahul1001@users.noreply.github.com> Co-authored-by: GPK <gopidesupavan@gmail.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>

…pache#47202) After apache#46942 - we should wait for UI not WWW asset compilation in the start-airlfow command.

…up (#73025) The readiness banner is the signal developers wait on before opening the browser, so it has to account for the component that serves it. The API server is the slowest of the four to come up, and until it binds its port the banner points users at a connection they cannot make. The port check existed from the command's introduction and was lost as collateral damage when the old webserver was removed: #46942 deleted the attribute holding the port but left the call reading it, and the follow-up hot-fix #47145 resolved the resulting AttributeError by deleting the call rather than repointing it at the renamed config key. The probe and its tests have been unreachable since. Resolving the port once during startup, as the pre-#47145 code did, also keeps a raising config lookup out of the poll loop, whose only handler is KeyboardInterrupt and whose component shutdown sits after the try block. Co-authored-by: Eason09053360 <185830721+Eason09053360@users.noreply.github.com>

…up (apache#73025) The readiness banner is the signal developers wait on before opening the browser, so it has to account for the component that serves it. The API server is the slowest of the four to come up, and until it binds its port the banner points users at a connection they cannot make. The port check existed from the command's introduction and was lost as collateral damage when the old webserver was removed: apache#46942 deleted the attribute holding the port but left the call reading it, and the follow-up hot-fix apache#47145 resolved the resulting AttributeError by deleting the call rather than repointing it at the renamed config key. The probe and its tests have been unreachable since. Resolving the port once during startup, as the pre-apache#47145 code did, also keeps a raising config lookup out of the poll loop, whose only handler is KeyboardInterrupt and whose component shutdown sits after the try block. Co-authored-by: Eason09053360 <185830721+Eason09053360@users.noreply.github.com>

bbovenzi requested review from ashb, dstandish, eladkal, ephraimbuddy, hussein-awala, jedcunningham, jscheffl, o-nikolas, pierrejeambrun, potiuk and ryanahamilton as code owners February 20, 2025 21:27

boring-cyborg Bot added area:CLI area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 20, 2025

bbovenzi mentioned this pull request Feb 20, 2025

Remove old UI and webserver #46871

Closed

Lee-W mentioned this pull request Feb 21, 2025

"Check it out" link to New UI does not work #46514

Closed

1 of 2 tasks

Lee-W self-requested a review February 21, 2025 03:15

potiuk approved these changes Feb 24, 2025

View reviewed changes

potiuk reviewed Feb 26, 2025

View reviewed changes

Comment thread clients/python/test_python_client.py Resolved

potiuk approved these changes Feb 26, 2025

View reviewed changes

jedcunningham approved these changes Feb 27, 2025

View reviewed changes

jedcunningham merged commit 5141554 into main Feb 27, 2025

bbovenzi deleted the remove-legacy-ui branch February 27, 2025 02:00

molcay mentioned this pull request Feb 27, 2025

Fix standalone command by removing the usage of webserver_port property #47145

Merged

vincbeck mentioned this pull request Feb 27, 2025

Remove api_connexion #47158

Closed

jscheffl mentioned this pull request Feb 27, 2025

Remove api_connexion #47171

Merged

ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 28, 2025

Don't run the webserver anymore on Airflow3 with `breeze start-airflo…

433308b

…w`. (apache#47060) Relates to apache#46942

potiuk added a commit to potiuk/airflow that referenced this pull request Feb 28, 2025

Fix waiting for UI asset compilation instead of WWW in start-airflow

9101d50

After apache#46942 - we should wait for UI not WWW asset compilation in the start-airlfow command.

potiuk mentioned this pull request Feb 28, 2025

Fix waiting for UI asset compilation instead of WWW in start-airflow #47202

Merged

potiuk added a commit that referenced this pull request Feb 28, 2025

Fix waiting for UI asset compilation instead of WWW in start-airflow (#…

4a0b8f3

…47202) After #46942 - we should wait for UI not WWW asset compilation in the start-airlfow command.

jedcunningham mentioned this pull request Mar 29, 2025

Status of testing of Apache Airflow Helm Chart 1.16.0rc1 #48531

Closed

12 of 62 tasks

aaron-y-chen pushed a commit to aaron-y-chen/airflow that referenced this pull request Apr 4, 2025

Don't run the webserver anymore on Airflow3 with `breeze start-airflo…

753d362

…w`. (apache#47060) Relates to apache#46942

Eason09053360 mentioned this pull request Sep 12, 2026

Fix airflow standalone announcing readiness before the API server is up #73025

Merged

1 task done

This was referenced Oct 1, 2026

Pod name incorrect in RenderedTaskInstanceFields #28186

Closed

Auto-refresh and DAG double-trigger issues when toggling pause #35220

Closed

Eason09053360 mentioned this pull request Oct 16, 2026

Add Eason09053360's February to October contribution report for apache-airflow opensource4you/readme#44

Merged

Conversation

bbovenzi commented Feb 20, 2025

Uh oh!

jedcunningham commented Feb 20, 2025

Uh oh!

uranusjr commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jscheffl commented Feb 21, 2025

Uh oh!

potiuk commented Feb 21, 2025

Uh oh!

jscheffl commented Feb 21, 2025

Uh oh!

potiuk commented Feb 21, 2025

Uh oh!

jscheffl commented Feb 22, 2025

Uh oh!

potiuk commented Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jedcunningham commented Feb 23, 2025

Uh oh!

pierrejeambrun commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

potiuk commented Feb 24, 2025

Uh oh!

Uh oh!

potiuk commented Feb 26, 2025

Uh oh!

bbovenzi commented Feb 27, 2025

Uh oh!

bugraoz93 commented Feb 27, 2025

Uh oh!

pierrejeambrun commented Feb 27, 2025

Uh oh!

jscheffl commented Feb 27, 2025

Uh oh!

potiuk commented Feb 27, 2025

Uh oh!

shahar1 commented Mar 1, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

uranusjr commented Feb 21, 2025 •

edited

Loading

potiuk commented Feb 23, 2025 •

edited

Loading

pierrejeambrun commented Feb 24, 2025 •

edited

Loading