Repository navigation
Fix standalone command by removing the usage of webserver_port property - #47145
Merged
Merged
Conversation
potiuk
approved these changes
Feb 27, 2025
Sharashchandra
pushed a commit
to Sharashchandra/airflow
that referenced
this pull request
Feb 28, 2025
aaron-y-chen
pushed a commit
to aaron-y-chen/airflow
that referenced
this pull request
Apr 4, 2025
1 task done
potiuk
pushed a commit
that referenced
this pull request
Sep 12, 2026
…up (#73025) The readiness banner is the signal developers wait on before opening the browser, so it has to account for the component that serves it. The API server is the slowest of the four to come up, and until it binds its port the banner points users at a connection they cannot make. The port check existed from the command's introduction and was lost as collateral damage when the old webserver was removed: #46942 deleted the attribute holding the port but left the call reading it, and the follow-up hot-fix #47145 resolved the resulting AttributeError by deleting the call rather than repointing it at the renamed config key. The probe and its tests have been unreachable since. Resolving the port once during startup, as the pre-#47145 code did, also keeps a raising config lookup out of the poll loop, whose only handler is KeyboardInterrupt and whose component shutdown sits after the try block. Co-authored-by: Eason09053360 <185830721+Eason09053360@users.noreply.github.com>
xvega
pushed a commit
to xvega/airflow
that referenced
this pull request
Sep 13, 2026
…up (apache#73025) The readiness banner is the signal developers wait on before opening the browser, so it has to account for the component that serves it. The API server is the slowest of the four to come up, and until it binds its port the banner points users at a connection they cannot make. The port check existed from the command's introduction and was lost as collateral damage when the old webserver was removed: apache#46942 deleted the attribute holding the port but left the call reading it, and the follow-up hot-fix apache#47145 resolved the resulting AttributeError by deleting the call rather than repointing it at the renamed config key. The probe and its tests have been unreachable since. Resolving the port once during startup, as the pre-apache#47145 code did, also keeps a raising config lookup out of the poll loop, whose only handler is KeyboardInterrupt and whose component shutdown sits after the try block. Co-authored-by: Eason09053360 <185830721+Eason09053360@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging the PR #46942 , when I try to run Airflow standalone, it will fail due to a missing property named
webserver_port.This PR will remove the usage of
webserver_portas well.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.