fix: prevent log loading from scrolling ancestor elements in task Logs tab#64889
Open
Pyasma wants to merge 1 commit intoapache:v2-11-testfrom
Open
fix: prevent log loading from scrolling ancestor elements in task Logs tab#64889Pyasma wants to merge 1 commit intoapache:v2-11-testfrom
Pyasma wants to merge 1 commit intoapache:v2-11-testfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #64757
Problem
When switching to the Logs tab on a task with many log lines, the entire details panel scrolls irreversibly instead of just the log box.
Root cause:
scrollToBottom()calledscrollIntoView()on a sentinel<div>at the bottom of log content.scrollIntoViewwalks up the DOM tree scrolling every ancestor element until the target is visible — sodiv.c-5s5pdh(the details panel) was being scrolled, not just the log box.Fix
LogBlock.tsx<div dangerouslySetInnerHTML={{ __html: parsedLogs }} /> - <div ref={codeBlockBottomDiv} />scrollTop = scrollHeightsets the scroll position directly on the log box element only. Nothing outside it moves.useOffsetTop.tsUpdated parameter type to accept
nullinside the generic — required becauseuseRef<HTMLElement>(null)now returnsRefObject<HTMLElement | null>in newer React/TypeScript versions.Was generative AI tooling used to co-author this PR?