fix: prevent log loading from scrolling ancestor elements in task Logs tab#64896
Closed
Pyasma wants to merge 2 commits intoapache:v2-11-testfrom
Closed
fix: prevent log loading from scrolling ancestor elements in task Logs tab#64896Pyasma wants to merge 2 commits intoapache:v2-11-testfrom
Pyasma wants to merge 2 commits intoapache:v2-11-testfrom
Conversation
Contributor
Author
|
Closing in favour of #64889 which has a cleaner diff (no unrelated file). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #64757
Problem
When switching to the Logs tab on a task instance with many log lines,
scrollIntoView()was called on a sentinel<div>at the bottom of the log content. This API walks up the DOM tree and scrolls every scrollable ancestor until the target is visible — causing the details panel (and page) to scroll irreversibly, not just the log box itself.Fix
Replace
scrollIntoView()with a directscrollTop = scrollHeightassignment on the log box element (logBoxRef). This only scrolls the log box itself, leaving all ancestor elements untouched.Also updated
useOffsetTopto acceptRefObject<HTMLElement | null>to align with the stricter ref types in newer React/TypeScript versions.Changes
airflow/www/static/js/dag/details/taskInstance/Logs/LogBlock.tsx— replacedscrollIntoViewwith directscrollTopscroll; removed unused sentinel<div>airflow/www/static/js/utils/useOffsetTop.ts— updated parameter type toRefObject<HTMLElement | null>Was generative AI tooling used to co-author this PR?